Skip to content

[Security] Bump moment-timezone from 0.5.34 to 0.5.37

Dependabot requested to merge dependabot-npm_and_yarn-moment-timezone-0.5.37 into master

Bumps moment-timezone from 0.5.34 to 0.5.37. This update includes security fixes.

Vulnerabilities fixed

Command Injection in moment-timezone

Impact

All versions of moment-timezone from 0.1.0 contain build tasks vulnerable to command injection.

  • if Alice uses tzdata pipeline to package moment-timezone on her own (for example via grunt data:2014d, where 2014d stands for the version of the tzdata to be used from IANA's website),
  • and Alice let's Mallory select the version (2014d in our example), then Mallory can execute arbitrary commands on the machine running the grunt task, with the same privilege as the grunt task

Am I affected?

Do you build custom versions of moment-timezone with grunt?

If no, you're not affected.

Do you allow a third party to specify which particular version you want build?

If yes, you're vulnerable to command injection -- third party may execute arbitrary commands on the system running grunt task with the same privileges as grunt task.

Description

Command Injection via grunt-zdownload.js and MITM on iana's ftp endpoint

... (truncated)

Patched versions: 0.5.35 Affected versions: >= 0.1.0, < 0.5.35

Cleartext Transmission of Sensitive Information in moment-timezone

Impact

  • if Alice uses grunt data (or grunt release) to prepare a custom-build, moment-timezone with the latest tzdata from IANA's website
  • and Mallory intercepts the request to IANA's unencrypted ftp server, Mallory can serve data which might exploit further stages of the moment-timezone tzdata pipeline, or potentially produce a tainted version of moment-timezone (practicality of such attacks is not proved)

Patches

Problem has been patched in version 0.5.35, patch should be applicable with minor modifications to all affected versions. The patch includes changing the FTP endpoint with an HTTPS endpoint.

Workarounds

Specify the exact version of tzdata (like 2014d, full command being grunt data:2014d, then run the rest of the release tasks by hand), or just apply the patch before issuing the grunt command.

Patched versions: 0.5.35 Affected versions: >= 0.1.0, < 0.5.35

Release notes

Sourced from moment-timezone's releases.

Release 0.5.37

Release 0.5.36

  • Updated data to IANA TZDB 2022c
  • Improvements/fixes to data pipeline

Release 0.5.35

Thanks to the OpenSSF Alpha-Omega project for reporting these!

Changelog

Sourced from moment-timezone's changelog.

0.5.37 2022-08-25

0.5.36 2022-08-25

  • IANA TZDB 2022c
  • improvements/fixes to data pipeline

0.5.35 2022-08-23

Thanks to the OpenSSF Alpha-Omega project for reporting these!

Commits
  • ffe6f34 Add changelog for 0.5.37
  • 450ca63 Bump version to 0.5.37
  • 95f1a9b Build moment-timezone 0.5.36
  • abba28c Add changelog for 0.5.36
  • ac6de03 Bump version to 0.5.36
  • 7a5cadf tests: Fix country tests for 2022c
  • 6754c75 data: generate 2022c data+tests
  • f74a364 bugfix: Wipe tests/zones before generation
  • e850f9f grunt: do not bundle zone and contry tests
  • f13e22b data: automatically create data/*/VERSION.json for latest
  • Additional commits viewable in compare view

Dependabot commands
You can trigger Dependabot actions by commenting on this MR
  • $dependabot rebase will rebase this MR
  • $dependabot recreate will recreate this MR rewriting all the manual changes and resolving conflicts

Merge request reports